New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoIP address lookup for players #3145
base: master
Are you sure you want to change the base?
Conversation
I am strongly against this pull request due to such feature being used in political arguments (and likely only in them) as well as lowering privacy of the players. Hosts that have geoIP feature must be labeled in lobby and it is not happening without altering current lobby system. There is a reason why on Autohoster website we do not have it. It should be either opt-in by a player (perhaps by providing your own not geoIP based flag in settings) or opt-out, as well as ability for host to disable all geoIP transmissions. Second problem is the GUI space. What if I do not want to see flags? There should be a setting to hide them on the client side. Personally I see this flag being too big. |
What is this nonsense? This feature is in half of the games that have multiplayer, this is the first time I've heard anything like this. Knowing what country the player is from is useful information. I don't give a damn about some political conversations and shit, please, do it on social media.
Players have no privacy by default because the host always knows the IP address of the players. A different thing is that the players do not know each other's IP address, which is why I only send the country code, not the IP address to all players so this feature can be disabled on host.
On the contrary, I made the flag smaller and was afraid it would be hard to recognize. I've tried different options to keep the text from overlapping it, it's a problem that occurs a lot in Warzone. |
That half that has this feature has chat moderation and Warzone 2100 does not nor will have one. Adding a flag will only provide basis for political arguments in chat and nothing more. Points about privacy still stand, such thing must be opt-in or at very least have an opt-out. I will manually patch it out of Autohoster if there will be no way to disable such thing. Many people do not want their location data to be broadcasted to everyone in the room. |
What do flags have to do with anything? All it takes is a player with the nickname "Adolf Hitler" to write shit like "All jews must die" in the chat room. There is no moderation in other games either.
Because I want to know which player is from which country to understand if they speak English, for example, the same is useful for other languages. I don't know why you bring politics into this, because it's nonsense.
I took this into account, so I added an option so that the host can disable the broadcasting of country codes to all players if necessary. |
Motivation:
I had to edit the network code so that the host sends country codes to all players, and edit the UI a bit to fit the flags. Country flags comply with the ISO 3166-1 standard. I got them from here. https://flagicons.lipis.dev/
I used an older version of GeoIP, many projects still use it. The IP address database is taken from here: https://mailfud.org/geoip-legacy/
The best way is to ship it together with the game resources. Although many projects, download it directly from the site.