FIX #232: bidi is loaded too early #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daamien
force-pushed
the
bug_bidi_persian
branch
2 times, most recently
from
9e3b3fb
to
52f8f21
Compare
* move caption and mdframed packages before bidi * comment the second load of polyglossia * test case for the bidi (right-to-left) bug
daamien
force-pushed
the
bug_bidi_persian
branch
from
52f8f21
to
eeb2c55
Compare
daamien
changed the title
daamien
changed the title
|
Thank you very much for this PR. The build looks good on my machine. Unfortunately I currently don't have the time to review and merge this so the PR might be open for a little longer. I'm working on it as soon as possible. |
|
Hi Thanks for the feedback ! |
|
Hi, I found one remaining problem with caption package loading after bidi that causes a xelatex error when setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.