refactor: add in-app browser check for mobile #2219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
approved these changes
May 7, 2024
enesozturk
force-pushed
the
refactor/update-is-mobile-check
branch
from
e46269f
to
f4907ab
Compare
enesozturk
commented
May 7, 2024
| isMobile() { | ||
| if (typeof window !== 'undefined') { | ||
| return ( | ||
| this.isInAppBrowser() || |
There was a problem hiding this comment.
Adding this somehow breaks the e2e tests. Prob it's going into some unexpected conditions. Will check later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Adde in-app browser checks to be sure that if the app is opened on any wallet's in-app browser, it should be detected as mobile as well