[Draft] feat: support web3js #2205

Muhammad-Altabba · 2024-05-03T12:46:13Z

This is currently just a draft.

This MR is to support using web3.js with web3modal.

Breaking Changes

N/A

Changes

feat: support web3js
chore: read EMAIL_DOMAIN from env variable (and default to 'web3modal.msdc.co' if not provided).

Associated Issues

N/A

* draft version for web3.js * add code for web3.js to apps/laboratory

* fix and ensure mail tests passing at laboratory * add EMAIL_DOMAIN to env variables * update .env.example

vercel · 2024-05-03T12:46:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
web3modal-gallery	❌ Failed (Inspect)		May 16, 2024 6:17pm

vercel · 2024-05-03T12:46:19Z

@Muhammad-Altabba is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

* use web3.js sub-packages at laboratory

* use web3js sub packages at `packages/web3`

glitch-txs · 2024-05-06T01:35:54Z

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

…dal-web3js

Muhammad-Altabba · 2024-05-08T10:43:04Z

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

Thanks @glitch-txs,
We hope this PR gives some ideas on how web3.js could be used with web3modal. Let us know please if we need to provide support for the code changes that would simplify the support of ethers and web3.js into the anticipated single package.

And for now, I published a temporary package as a demo at: https://www.npmjs.com/package/web3modal-web3js

Best regards,

* chore(lab): dogfooding button (WalletConnect#2206) * chore: fix typos (WalletConnect#2188) Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * refactor: render tooltip in root (WalletConnect#2210) * feat: add react-ethers 6 example (WalletConnect#1920) Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> * refactor: swap business logic improvements (WalletConnect#2199) * chore: detailed canary timings (WalletConnect#2214) * chore: add apple app site association (WalletConnect#2216) * :feat add send logic (WalletConnect#2173) Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * fix: apple-app-site-association content type header (WalletConnect#2217) * feat: Sign 2.5 (WalletConnect#2033) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * feat: Smart Account 6492 Signature Tests (WalletConnect#2196) * fix: sign modal not appearing when going through siwe flow (WalletConnect#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (WalletConnect#2190) Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> * fix: missing call to SIWE `onSignOut` (WalletConnect#2054) Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (WalletConnect#1689) Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com> Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :deprecate - injected connector (WalletConnect#2223) * chore: more canary timings (WalletConnect#2215) * chore: updates ethereum-provider to latest (WalletConnect#2226) * fix: add assertion for the erc20 abi json import (WalletConnect#2225) * update packages --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Luka Isailovic <lukaisailovic@gmail.com> Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: GooxPF <gooxpf@gmail.com> Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> Co-authored-by: Tiến Nguyễn Khắc <tien.nguyenkhac@icloud.com> Co-authored-by: Nikos Rossolatos <nikos@cointracker.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com>

* chore(lab): dogfooding button (WalletConnect#2206) * chore: fix typos (WalletConnect#2188) Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * refactor: render tooltip in root (WalletConnect#2210) * feat: add react-ethers 6 example (WalletConnect#1920) Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> * refactor: swap business logic improvements (WalletConnect#2199) * chore: detailed canary timings (WalletConnect#2214) * chore: add apple app site association (WalletConnect#2216) * :feat add send logic (WalletConnect#2173) Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * fix: apple-app-site-association content type header (WalletConnect#2217) * feat: Sign 2.5 (WalletConnect#2033) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> * feat: Smart Account 6492 Signature Tests (WalletConnect#2196) * fix: sign modal not appearing when going through siwe flow (WalletConnect#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (WalletConnect#2190) Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> * fix: missing call to SIWE `onSignOut` (WalletConnect#2054) Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (WalletConnect#1689) Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com> Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :deprecate - injected connector (WalletConnect#2223) * chore: more canary timings (WalletConnect#2215) * chore: updates ethereum-provider to latest (WalletConnect#2226) * fix: add assertion for the erc20 abi json import (WalletConnect#2225) * fix: encodes all `personal_sign` messages to hex (WalletConnect#2237) Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> * fix: siwe tests for 1 click auth (WalletConnect#2267) * feat: phantom deeplink for mobile app browsers (WalletConnect#2250) Co-authored-by: tomiir <rocchitomas@gmail.com> * fix: 4.2.0 bug fixes (WalletConnect#2234) Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> * chore: UI canary 10 minute timeout (WalletConnect#2269) * chore: bump to main 4.2.0 version (WalletConnect#2270) * :feat social login - 1 - UI (WalletConnect#2266) Co-authored-by: enesozturk <enesozturk.d@gmail.com> * :feat social login - 2 - Wallet (WalletConnect#2272) * :feat social login - 3 - AuthConnector (WalletConnect#2274) * refactor: update profile name rendering logic (WalletConnect#2276) * :hotfix in app support for injected and announced wallets (WalletConnect#2279) * refactor/theme variables and v4 ui updates (WalletConnect#2277) --------- Signed-off-by: snoppy <michaleli@foxmail.com> Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: tomiir <rocchitomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: Luka Isailovic <lukaisailovic@gmail.com> Co-authored-by: Cali93 <32299095+Cali93@users.noreply.github.com> Co-authored-by: Gancho Radkov <43912948+ganchoradkov@users.noreply.github.com> Co-authored-by: Gancho Radkov <ganchoradkov@gmail.com> Co-authored-by: Glitch <glitch.txs@gmail.com> Co-authored-by: Glitch <66949816+glitch-txs@users.noreply.github.com> Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: GooxPF <gooxpf@gmail.com> Co-authored-by: Valentyn <valentin.vad.sh@gmail.com> Co-authored-by: Tiến Nguyễn Khắc <tien.nguyenkhac@icloud.com> Co-authored-by: Nikos Rossolatos <nikos@cointracker.com> Co-authored-by: Ilja <3154053+xzilja@users.noreply.github.com>

* chore(lab): dogfooding button (WalletConnect#2206) * add web3 examples * update example --------- Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>

glitch-txs · 2024-05-17T11:30:08Z

Thanks @Muhammad-Altabba! We are planning to migrate from ethers support to a more agnostic approach by exposing the wallet provider on its own so devs would be able to work/choose any ethereum library they wish to use

enesozturk · 2024-05-21T08:19:19Z

Hey @Muhammad-Altabba, thank you for such a big contribution. We are working on a general structure refactor for web3modal and as @glitch-txs mentioned we won't need to implement web3.js client explicitly and it'll be library agnostic.

So, closing this for now. But will keep in mind if we need to follow this way. We appreciate your effort. Best!

Muhammad-Altabba added 5 commits April 23, 2024 15:06

feat: Support web3.js - basic draft implementation (#2)

5f83f4e

* draft version for web3.js * add code for web3.js to apps/laboratory

feat: support web3js patch 2: fix email testing (#3)

d1baf4c

* fix and ensure mail tests passing at laboratory * add EMAIL_DOMAIN to env variables * update .env.example

Merge branch 'WalletConnect:V4' into feat/support-web3js

8d7b212

update dependencies versions

8a4eda1

update web3 test for the latest changes

6ca88fa

vercel bot deployed to Preview – web3modal-gallery May 3, 2024 12:48 View deployment

Muhammad-Altabba added 2 commits May 4, 2024 13:22

feat:support web3js - patch 3: use minimal packages at laboratory (#12)

5784d52

* use web3.js sub-packages at laboratory

feat: support web3js patch 4 use web3js sub-packages (#13)

73df375

* use web3js sub packages at `packages/web3`

vercel bot deployed to Preview – web3modal-gallery May 4, 2024 11:28 View deployment

Muhammad-Altabba mentioned this pull request May 4, 2024

feat: support web3js ChainSafe/web3modal#14

Open

run prettier:format

b593ff3

vercel bot deployed to Preview – web3modal-gallery May 4, 2024 11:40 View deployment

vercel bot deployed to Preview – web3modal-gallery May 4, 2024 11:44 View deployment

use strict versioning at apps/laboratory/package.json

9d8c5f1

Muhammad-Altabba force-pushed the feat/support-web3js branch from 993537b to 9d8c5f1 Compare May 4, 2024 11:45

vercel bot deployed to Preview – web3modal-gallery May 4, 2024 11:48 View deployment

vercel bot deployed to Preview – web3modal-gallery May 5, 2024 21:53 View deployment

vercel bot deployed to Preview – web3modal-gallery May 7, 2024 17:39 View deployment

modify version and md files

4ffd570

Muhammad-Altabba force-pushed the feat/support-web3js branch from 6d92b98 to 4ffd570 Compare May 8, 2024 10:24

vercel bot had a problem deploying to Preview – web3modal-gallery May 8, 2024 10:24 Failure

luu-alex and others added 2 commits May 8, 2024 12:26

update contract test (#17)

50410b8

use a temporary name for web3js sub-package: web3modal-web3js

68bab8e

vercel bot had a problem deploying to Preview – web3modal-gallery May 8, 2024 10:30 Failure

update according to the temporary name for web3js sub-package: web3mo…

e31b1a6

…dal-web3js

vercel bot deployed to Preview – web3modal-gallery May 8, 2024 10:39 View deployment

fix for prettier

5ec5055

vercel bot deployed to Preview – web3modal-gallery May 8, 2024 12:21 View deployment

vercel bot had a problem deploying to Preview – web3modal-gallery May 13, 2024 16:27 Failure

vercel bot had a problem deploying to Preview – web3modal-gallery May 16, 2024 18:05 Failure

vercel bot had a problem deploying to Preview – web3modal-gallery May 16, 2024 18:06 Failure

Merge branch 'V4' into feat/support-web3js

453963f

vercel bot had a problem deploying to Preview – web3modal-gallery May 16, 2024 18:17 Failure

enesozturk closed this May 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft] feat: support web3js #2205

[Draft] feat: support web3js #2205

Muhammad-Altabba commented May 3, 2024

vercel bot commented May 3, 2024 •

edited

vercel bot commented May 3, 2024

glitch-txs commented May 6, 2024

Muhammad-Altabba commented May 8, 2024

glitch-txs commented May 17, 2024

enesozturk commented May 21, 2024

[Draft] feat: support web3js #2205

[Draft] feat: support web3js #2205

Conversation

Muhammad-Altabba commented May 3, 2024

Breaking Changes

Changes

Associated Issues

vercel bot commented May 3, 2024 • edited

vercel bot commented May 3, 2024

glitch-txs commented May 6, 2024

Muhammad-Altabba commented May 8, 2024

glitch-txs commented May 17, 2024

enesozturk commented May 21, 2024

vercel bot commented May 3, 2024 •

edited