Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rejection tags #4527

Merged
merged 6 commits into from May 14, 2024
Merged

feat: rejection tags #4527

merged 6 commits into from May 14, 2024

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented May 10, 2024 •
edited

Description

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label May 10, 2024
@ganchoradkov ganchoradkov marked this pull request as ready for review May 13, 2024 08:10
@bkrem bkrem requested a review from jakubuid May 13, 2024 09:39
Cali93
Cali93 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌
I just have small suggestions

packages/sign-client/src/controllers/engine.ts Show resolved Hide resolved
packages/sign-client/src/controllers/engine.ts Outdated Show resolved Hide resolved
packages/sign-client/test/sdk/auth.spec.ts Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit 819a8a4 into v2.0 May 14, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the feat/rejection-tags branch May 14, 2024 13:25
@ganchoradkov ganchoradkov mentioned this pull request May 23, 2024
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

@jakubuid jakubuid jakubuid approved these changes

@Cali93 Cali93 Cali93 approved these changes

@lukaisailovic lukaisailovic Awaiting requested review from lukaisailovic

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ganchoradkov @bkrem @jakubuid @Cali93 @arein