Feat/wallet get capabilities cache #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arein
approved these changes
May 2, 2024
| capabilities: { | ||
| ...(sessionCapabilities || {}), | ||
| [address]: capabilities, | ||
| } as any, // by spec sessionProperties should be <string, string> but here are used as objects? |
There was a problem hiding this comment.
what do we do about this? The spec is the EIP-5792 spec. I think we do something else maybe in our CAIP-25 spec? So maybe we just cover the "right" think in our wallet docs / wallet SDK?
We probably need to expand our namespace builder for this usecase
There was a problem hiding this comment.
according to caip-25 spec the sessionProperties (scopeProperties) is <string, string>
| @@ -1001,6 +1002,78 @@ describe("UniversalProvider", function () { | |||
| expectedChainId, | |||
| }); | |||
| }); | |||
| it("should cache `wallet_getCapabilities` request", async () => { | |||
There was a problem hiding this comment.
do you need a negative test here if not cached?
There was a problem hiding this comment.
the first part of the test where the wallet receives the request covers the not cached part. If it was cached already the request wouldn't have been sent to the wallet
tomiir
approved these changes
May 8, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
wallet_getCapabilitiescaching inuniversal-providerType of change
How has this been tested?
tests
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.