Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core replay protection #3621

Open
wants to merge 8 commits into
base: v2.0
Choose a base branch
from
Open

Conversation

pedrouid
Copy link
Member

@pedrouid pedrouid commented Sep 9, 2023

Description

This introduces replay protection for each typed enveloped based on the topic

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

THIS IS STILL MISSING TESTING!

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@arein arein added the accepted label Sep 9, 2023
@paulmillr
Copy link

@pedrouid can you check out security improvement issue instead of ignoring it? #3084

@pedrouid
Copy link
Member Author

@pedrouid can you check out security improvement issue instead of ignoring it? #3084

@paulmillr please do not comment on unrelated PRs to elevate the awareness of another issue

This type of commentary is unproductive so please see my response on #3084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants