Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings to boilerplate #236

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

erikyo
Copy link
Contributor

@erikyo erikyo commented May 9, 2023

This pull request adds TypeScript typings to the WordPress plugin boilerplate, providing type annotations for key functions and variables in the code. The changes include adding TypeScript declarations for the Plugin class, the Plugin_Options class, and various hooks and filters used throughout the code.

By adding TypeScript typings, this pull request improves code quality and readability, making it easier for developers to understand and extend the plugin boilerplate. The changes also help to catch errors earlier in the development process, reducing the time and effort required for debugging.

Overall, this change represents a significant improvement to the plugin boilerplate, and will help to promote high-quality, reliable WordPress plugins in the future. I hope you enjoyed it too, I look forward to a review!

@erikyo
Copy link
Contributor Author

erikyo commented May 9, 2023

cc @johnhooks how it looks in vscode?

@johnhooks
Copy link
Contributor

@erikyo I checked it out and made some updates

@Mte90 Mte90 merged commit ed53648 into WPBP:master May 9, 2023
@erikyo erikyo deleted the js/typed-js branch May 9, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants