feat(impexp): improved code readability

WPBP · May 19, 2023 · b897c7a · b897c7a
1 parent 0274d53
commit b897c7a
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/plugin-name/backend/ImpExp.php b/plugin-name/backend/ImpExp.php
@@ -29,10 +29,12 @@ public function initialize() {
 			return;
 		}
 
-		// Add the export settings method
-		\add_action( 'admin_init', array( $this, 'settings_export' ) );
-		// Add the import settings method
-		\add_action( 'admin_init', array( $this, 'settings_import' ) );
+		if ( \current_user_can( 'manage_options' ) ) {
+			// Add the export settings method
+			\add_action( 'admin_init', array( $this, 'settings_export' ) );
+			// Add the import settings method
+			\add_action( 'admin_init', array( $this, 'settings_import' ) );
+		}
 	}
 
 	/**
@@ -53,10 +55,6 @@ public function settings_export() {
 			return;
 		}
 
-		if ( !\current_user_can( 'manage_options' ) ) {
-			return;
-		}
-
 		$settings      = array();
 		$settings[ 0 ] = \get_option( PN_TEXTDOMAIN . '-settings' );
 		$settings[ 1 ] = \get_option( PN_TEXTDOMAIN . '-settings-second' );
@@ -91,10 +89,10 @@ public function settings_import() {
 			return;
 		}
 
-		if ( !\current_user_can( 'manage_options' ) ) {
+		if ( !isset( $_FILES[ 'pn_import_file' ][ 'name' ] ) ) {
 			return;
 		}
-
+		
 		$file_name_parts = \explode( '.', $_FILES[ 'pn_import_file' ][ 'name' ] ); //phpcs:ignore WordPress.Security.ValidatedSanitizedInput
 		$extension       = \end( $file_name_parts );