Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french bible versions for verses #264

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add french bible versions for verses #264

wants to merge 1 commit into from

Conversation

rjorel
Copy link

@rjorel rjorel commented Oct 28, 2019

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project. (WPCS)
  • My change requires a change to the documentation.

Brief description of the proposed change:

Hi, I added Bible versions for my native language.

Any other info:

I do not know if it's a choice to only have english versions, without possibility to select more versions among the list of possible ones on https://biblia.com, so I only added ones for French.

I did not find the code responsible for parsing verse abbreviations, but if you merge this PR and say to me how to do it, I would like to add french abbreviation parsing.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant