Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More wide use of AUTO_LANGUAGE in SPARQL queries #2310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Jul 24, 2023

Fixes #1

Description

Uses AUTO_LANGUAGE more often in SPARQL queries allowing the WDQS to pick up the language used in the web browser.

Caveats

It does not solve picking the language when rdfs:label is used in combination with FILTER lang().

Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

Testing

This patch touches on a lot of SPARQL queries, in the following aspects:

404-chemical
author
author-curation
author-index.html
authors
award
award-curation
chemical
chemical-class
chemical-element
clinical-trial
clinical-trial-index
complex
countries
country
country-topic
dataset
disease
event
event-series
location
location-topic
organization
organizations
project
property
publisher
series
software
sponsor
topic
use
venue
venues
work
works

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw added enhancement some suggestions to improve Scholia internationalization making Scholia usable in more languages labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement some suggestions to improve Scholia internationalization making Scholia usable in more languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show non-english label if no English label exists
1 participant