Add set -e -o pipefail in pipeline scripts #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Yong <jason_yong@uk.ibm.com>
|
@davco01a wondering whether OnePipeline would fail the stage if a command (i.e. makefile call, invoking script) returns non-zero or if This is related to the issue where the failures were silent and not easily visible: https://github.ibm.com/IBMCloudPak4Apps/wshe-OnePipeline/issues/127 |
|
@yongja79 should these changes be ported to the common repo? |
|
@leochr I think we probably need to look at this again as the onepipeline scripts have changed significantly since this PR. Alot of the logic is now is separate scripts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated several of the build/test scripts so that they would fail on a no zero return code
Signed-off-by: Jason Yong jason_yong@uk.ibm.com