Update samples to use icr.io/appcafe and added image list #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BradleyMayo
commented
Apr 25, 2024
•
BradleyMayo
commented
- Cleaned up the start of the overall readme
- Removed reference to outdated helm chart
- Added image list similar to the one from liberty https://github.com/OpenLiberty/ci.docker/blob/main/docs/icr-images.md
- Updated samples to use icr.io/appcafe instead of ibmcom
- Updated build_all.sh script to pull from icr.io/appcafe instead of ibmcom
NottyCode
reviewed
Apr 25, 2024
README.md
Outdated
|
|
||
| **Note:** The 9.0.5.3 release images were the last version where `latest` and `9.0.5.#` tagged images were based upon Ubuntu v16.04 as the base operating system. Starting with the 9.0.5.4 release, the images are now based upon Red Hat Universal Base Image (UBI) 8 OS images. As always, you are welcome to build your own images using any base OS image that supports IBM WebSphere Application traditional. | ||
| You can pull the images built using this directory from both [Docker Hub](https://hub.docker.com/r/ibmcom/websphere-traditional/) and IBM Container Regsitry (icr.io). |
There was a problem hiding this comment.
still prefers docker hub to ICR
NottyCode
reviewed
Apr 25, 2024
README.md
Outdated
|
|
||
| When pulling from Docker Hub use the following format | ||
| ``` | ||
| FROM ibmcom/websphere-traditional:latest |
There was a problem hiding this comment.
I was suggesting we just remove these examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.