Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developed plugin version selection feature #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielemegna
Copy link

We developed the plugin version param to select a specific github release (or tag) to install on .vimrc:

Plugin 'kien/ctrlp.vim', {'version': '1.79'}

We also developed an automated bash test to check this functionality:

$ bash test/end2end/installSpecificPluginTagVersionTest.sh

We tested:

  • New installation with specified version
  • New installation with specified version and custom folder name
  • New installation without specified version (unchanged behavior)
  • Already present plugin installed with specified version and now reverted to not specified
  • Already present plugin installed with specified version and now different version
  • Already present plugin installed without specified version and now specified

@wsdjeg
Copy link
Contributor

wsdjeg commented Dec 15, 2015

@gmarik will you add this feature?as i known you want vundle keep as KISS as possible

@danielemegna
Copy link
Author

@wsdjeg imho it IS simple: the version attribute isn't mandatory of course and it would add a interested feature

@wsdjeg
Copy link
Contributor

wsdjeg commented Dec 18, 2015

i kown ,it will be easy to control version

@shaunbrady
Copy link

@danielemegna This code looks good. Can you rebase/resolve the merge conflicts? I would like to test it out.

@danielemegna
Copy link
Author

@shaunbrady sure, I can try it this weekend

@danielemegna
Copy link
Author

@shaunbrady it looks ok now, could you test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants