Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for the Heroku deployment (not working yet) #75

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-burel
Copy link
Contributor

Hi,

I drafted a 2-repo deployment for Heroku. However, it does not work yet, I think that the METEOR_PACKAGE_DIRS is incorrect though I can't fix it, as described in this issue

Also, I have no idea how you would handle a private repo for the custom Vulcan packages. However most of the time you'll use this kind of install either to enjoy the latest PR before they are merged into Vulcan or on the opposite to keep old versions of the packages, so I guess very few people will need to hide their packages code in a second private repo, they'll use the usual install process instead and put those private files directly into their app code.

Hi,

I drafted a 2-repo deployment for Heroku. However, it does not work yet, I think that the `METEOR_PACKAGE_DIRS` is incorrect though I can't fix it, as [described in this issue](AdmitHub/meteor-buildpack-horse#188
)

Also, I have no idea how you would handle a private repo for the custom Vulcan packages. However most of the time you'll use this kind of install either to enjoy the latest PR before they are merged into Vulcan or on the opposite to keep old versions of the packages, so I guess very few people will need to hide their packages code in a second private repo, they'll use the usual install process instead and put those private files directly into their app code.
@ErikDakoda
Copy link
Contributor

Hi @eric-burel, Do you want to merge this pull request into the current docs, or is this outdated?

@eric-burel
Copy link
Contributor Author

No I think we can leave it here. I was on the right track but I never had time to figure this out. Now I deploy on AWS instead or copy Vulcan in the code before pushing to Heroku but this doc is still (almost) relevant.

@eric-burel
Copy link
Contributor Author

Maybe someday someone will manage to this and help finishing this doc.

@ErikDakoda ErikDakoda marked this pull request as draft February 9, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants