Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(colors): Rework color palette to better match accent color #1641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Larsluph
Copy link
Collaborator

Before:

image

After:

image

Fixes #1639

@Larsluph Larsluph self-assigned this Apr 13, 2024
@Larsluph Larsluph requested a review from WDaan as a code owner April 13, 2024 09:33
@WDaan
Copy link
Collaborator

WDaan commented Apr 15, 2024

Personally not a big fan of the greenish hue that would be over everything.
I do agree that the current color palet could be tweaked/improved upon.

Seems like this issue is not being super upvoted by everybody, so perhaps this should be more of a public vote?

We could also make it customizable but I'm a bit afraid of the tech debt overhead that could/would generate.

@Larsluph
Copy link
Collaborator Author

Larsluph commented Apr 15, 2024

Seems like this issue is not being super upvoted by everybody, so perhaps this should be more of a public vote?

Totally agree with that, no idea how we could achieve that? On discord maybe? I heard they are currently releasing a polling system, we could try it.

We could also make it customizable but I'm a bit afraid of the tech debt overhead that could/would generate.

Adding several color palettes in the interface could be possible thanks to vuetify's theme customization. I don't think it's possible to make it fully customizable though, only predefined palettes...

@Larsluph
Copy link
Collaborator Author

@WDaan for this would you prefer a toggle to enable these alternative colors, or making a poll to replace the existing palette?

@WDaan
Copy link
Collaborator

WDaan commented Apr 29, 2024

I guess we could use Discord for some community input? What would they like to see changed? Maybe some minor adjustments are sufficient to resolve the issue. Nobody else has commented on it or posted a reaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Darken drawer background
2 participants