feat(Peers): Show client, peer_id, and i18n strings #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larsluph
requested changes
Mar 16, 2024
There was a problem hiding this comment.
Great contribution!
Although I would use interpolation for fields to better handle locale format
https://vue-i18n.intlify.dev/guide/essentials/syntax.html#interpolations
|
I don't think it's a good idea to hide the flag and client divs when the values are empty. Empty flags and clients are also useful infomation. |
Totally agree with that, I was referring to a i18n feature that allows to replace "variable" data into i18n messages. I included a link so that you can see the syntax. |
|
Anything left on this one? 🤔 |
Larsluph
approved these changes
May 1, 2024
WDaan
approved these changes
May 1, 2024
|
Updated UI to make it stand out.
|
Larsluph
added a commit
that referenced
this pull request
May 1, 2024
Co-authored-by: Z4HD <Z4HD@outlook.com> Co-authored-by: Larsluph <22910497+Larsluph@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(Peers): Show client, peer_id, and i18n strings
Improve peers info display, including:
See screenshot for details.
PR Checklist