Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Darken drawer background #1639

Open
1 task
FoxxMD opened this issue Apr 12, 2024 · 1 comment · May be fixed by #1641
Open
1 task

[Feature Request]: Darken drawer background #1639

FoxxMD opened this issue Apr 12, 2024 · 1 comment · May be fixed by #1641
Labels
Feature New Feature triage Issue hasn't been assessed yet

Comments

@FoxxMD
Copy link

FoxxMD commented Apr 12, 2024

Description

First off thank you for an fantastic skin for qbittorent! The mobile view is especially a massive help for daily use.

However, the drawer background color is driving me nuts. It is too close to the "highlighted element" color most browsers devtools use as well as being close to "selected content by dragging the mouse across a page" highlighter color.

image

My monkey brain sees the drawer color and thinks "this is erroneously highlighted for some reason" and just can't ignore it. 💀

Unfortunately I can't build my own VueTorrent because I run qbittorent through a container and use lsio docker mods for vuetorrent.

Describe the solution you'd like

I know this is quite a selfish and personal request but would it be possible to darken this color enough that it no longer resembles that highlighted color?

Something like rgb(26, 33, 40) would be enough

image

Describe alternatives you've considered

Currently I am using tampermonkey to modify styling on load

function waitForElm(selector) {
    return new Promise(resolve => {
        if (document.querySelector(selector)) {
            return resolve(document.querySelector(selector));
        }

        const observer = new MutationObserver(mutations => {
            if (document.querySelector(selector)) {
                observer.disconnect();
                resolve(document.querySelector(selector));
            }
        });
        observer.observe(document.body, {
            childList: true,
            subtree: true
        });
    });
}

(function() {
    waitForElm('nav.v-navigation-drawer').then((elm) => {
        console.log('Element is ready');
        document.querySelectorAll('nav.v-navigation-drawer .bg-primary').forEach(elm => elm.classList.remove('bg-primary'));
        document.querySelector('nav.v-navigation-drawer').style.setProperty('background-color', 'rgb(26, 33, 40)', 'important');
    });
})();

But this isn't feasible for mobile. And I'd prefer a true fix rather than hacking it like this.

Thanks for your time!

Complementary informations

  • Is this feature already implemented in the default WebUI?
@FoxxMD FoxxMD added Feature New Feature triage Issue hasn't been assessed yet labels Apr 12, 2024
@Larsluph
Copy link
Collaborator

Unfortunately I can't build my own VueTorrent because I run qbittorent through a container and use lsio docker mods for vuetorrent.

Well you could build your own by adding a mounted volume to your container, but you would have to update it.

I know some github apps that allows you to auto update your fork and keep it updated. You can combine it with the auto update methods from the wiki to have it automatically pull those changes into that mounted volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature triage Issue hasn't been assessed yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants