Unwanted selections don't switch to Visual Mode #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this behavior is ever desirable, but created this PR anyway so that we can discuss. I don't see any downsides from doing this. Visual mode works from key input and mouse selections. We just don't automatically switch to Visual Mode when Visual Studio decides that it wants to select some text for us by itself. Fixes #2966
nosami
commented
Mar 10, 2024
| if isSelectModeMouse then | ||
| Some ModeKind.SelectCharacter | ||
| else | ||
| None |
There was a problem hiding this comment.
This is the main change, the rest is mostly noise
|
Lots of tests failing but waiting for feedback before I look at those. |
jaredpar
approved these changes
Mar 11, 2024
|
So, there is a problem with this PR that needs resolving. Creating a selection with the keyboard without explicitly going into Visual Mode now no longer automatically switches to VisualCharacter mode (e.g pressing shift+down, shift + right etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this behavior is ever desirable, but created this PR anyway so that we can discuss. Maybe there is some scenario that I haven't considered.
I don't see any downsides from doing this. Visual mode still works via key input and mouse selections. We just don't automatically switch to Visual Mode when Visual Studio decides that it wants to select some text for us by itself.
Fixes #2966