Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning FS3548: #3092

Merged
merged 2 commits into from Feb 12, 2024
Merged

Fix warning FS3548: #3092

merged 2 commits into from Feb 12, 2024

Conversation

nosami
Copy link
Collaborator

@nosami nosami commented Feb 4, 2024

Pattern discard is not allowed for union case that takes no data.

I suppose this is a new warning generated by the F# compiler.

Pattern discard is not allowed for union case that takes no data.

I suppose this is a new warning generated by the F# compiler.
@nosami
Copy link
Collaborator Author

nosami commented Feb 4, 2024

@jaredpar I don't suppose you understand where these build errors are coming from? The build was working the last time I tried and there have been no other code changes since!

Seeing a lot of errors like this (both on CI and locally, even without my changes here)

D:\a\VsVim\VsVim\Binaries\obj\VsVim2019\Debug\net472\ConflictingKeyBindingMarginControl.g.cs(58,21): error CS1504: Source file 'ConflictingKeyBindingMarginControl.xaml' could not be opened -- Could not find file. [D:\a\VsVim\VsVim\Src\VsVim2019\VsVim2019_lxa1uue4_wpftmp.csproj]

@nosami
Copy link
Collaborator Author

nosami commented Feb 4, 2024

@jaredpar I don't suppose you understand where these build errors are coming from? The build was working the last time I tried and there have been no other code changes since!

Seeing a lot of errors like this (both on CI and locally, even without my changes here)

D:\a\VsVim\VsVim\Binaries\obj\VsVim2019\Debug\net472\ConflictingKeyBindingMarginControl.g.cs(58,21): error CS1504: Source file 'ConflictingKeyBindingMarginControl.xaml' could not be opened -- Could not find file. [D:\a\VsVim\VsVim\Src\VsVim2019\VsVim2019_lxa1uue4_wpftmp.csproj]

dotnet/sdk#34438 seems relevant here.

@nosami nosami requested a review from jaredpar February 5, 2024 10:24
@nosami nosami merged commit 8067489 into master Feb 12, 2024
3 checks passed
@nosami nosami deleted the dev/nosami/fix-pattern-discard-warnings branch February 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants