Place encodings in response's flags issue scrapy#1988

VorBoto · Sep 18, 2019 · ccbb524 · ccbb524
1 parent 25d4760
commit ccbb524
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/scrapy/downloadermiddlewares/httpcompression.py b/scrapy/downloadermiddlewares/httpcompression.py
@@ -48,17 +48,11 @@ def process_response(self, request, response, spider):
                     # force recalculating the encoding until we make sure the
                     # responsetypes guessing is reliable
                     kwargs['encoding'] = None
-
                 if self.keep_encoding_header:
-                    #check encoding of outgoing response
-                    #dont know if i can do this with a RespinceTypes object
-                    out_encoding = TextResponse(respcls)._body_inferred_encoding()
-                    kwargs['flags'] = out_encoding
-
+                    kwargs['flags'] = [encoding]
                 response = response.replace(**kwargs)
-                if not self.keep_encoding_header:
-                    if not content_encoding:
-                        del response.headers['Content-Encoding']
+                if not content_encoding:
+                    del response.headers['Content-Encoding']
         return response
 
     def _decode(self, body, encoding):

diff --git a/tests/test_downloadermiddleware_httpcompression.py b/tests/test_downloadermiddleware_httpcompression.py
@@ -28,7 +28,7 @@ class HttpCompressionTest(TestCase):
 
     def setUp(self):
         #need to find way to access settings here
-        crawler = get_crawler(Spider,{'HTTPCOMPRESSION_HEADERS_KEEP':False,
+        crawler = get_crawler(Spider,{'HTTPCOMPRESSION_HEADERS_KEEP':True,
                                       'COMPRESSION_ENABLED':True})
         self.spider = crawler._create_spider('foo')
         self.mw = HttpCompressionMiddleware.from_crawler(crawler)