-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ni v2 #265
base: main
Are you sure you want to change the base?
Conversation
… but try to use jwt auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just added a couple of comments.
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 97.33% 97.34%
=======================================
Files 25 26 +1
Lines 1090 1129 +39
=======================================
+ Hits 1061 1099 +38
- Misses 29 30 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@superchilled Have made your suggested changes 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adds Number Insight v2 functionality
Refactors regex checks into one function in the
_internal.py
module