Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ni v2 #265

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Add ni v2 #265

wants to merge 37 commits into from

Conversation

maxkahan
Copy link
Collaborator

Adds Number Insight v2 functionality
Refactors regex checks into one function in the _internal.py module

@superchilled superchilled self-requested a review June 22, 2023 11:08
Copy link
Contributor

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just added a couple of comments.

src/vonage/number_insight_v2.py Outdated Show resolved Hide resolved
src/vonage/_internal.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #265 (57426aa) into main (c57adff) will increase coverage by 0.00%.
The diff coverage is 98.03%.

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   97.33%   97.34%           
=======================================
  Files          25       26    +1     
  Lines        1090     1129   +39     
=======================================
+ Hits         1061     1099   +38     
- Misses         29       30    +1     
Files Changed Coverage Δ
src/vonage/number_insight_v2.py 96.00% <96.00%> (ø)
src/vonage/_internal.py 95.23% <100.00%> (+2.93%) ⬆️
src/vonage/client.py 94.29% <100.00%> (+0.05%) ⬆️
src/vonage/errors.py 100.00% <100.00%> (ø)
src/vonage/messages.py 100.00% <100.00%> (ø)
src/vonage/verify2.py 98.38% <100.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxkahan
Copy link
Collaborator Author

@superchilled Have made your suggested changes 🙂

Copy link
Contributor

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants