Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async behavior of the NCCO record action #446

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erickskrauch
Copy link
Contributor

Description

As described in the documentation, the record action is asynchronous by default, unless it has endOnSilence, timeOut or endOnKey params. The current implementation of the Record action in this library provides no way to not specify that param.

Motivation and Context

We need to achieve an async behavior of the record action.

How Has This Been Tested?

We have made calls with those changes.

Example Output or Screenshots (if appropriate):

Call CON-b4cc19a0-ffd7-4e44-80ec-2d7ecf05c44c.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK
Copy link
Contributor

This can be merged when it is time to release 5.0.0 (as although it's a fix, it's a semver breaking change in line with how the Record NCCO works currently)

@SecondeJK SecondeJK self-requested a review October 23, 2023 08:32
@SecondeJK SecondeJK self-assigned this Oct 23, 2023
@SecondeJK SecondeJK added the v5 Version 5 features/fixes label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Version 5 features/fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants