Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #222

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Patch 1 #222

wants to merge 45 commits into from

Conversation

mhmdrameez
Copy link

"Can't find Python executable "python""

What is this doing?

What kind of change does this PR introduce? (check at least one)

  • [ x] Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ x] No

If yes, please describe how it impacts the application:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. Fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ x] New/updated tests are included

Other information:

smaharj1 and others added 30 commits May 3, 2020 01:25
@smaharj1
Made changes to the UI for attributes modal not working
aff2004
@smaharj1
Changed the port to have the same one as docker. it was creating sock…
45fa535 
…js-error

Refactored the package.json
@Viveckh
Merge pull request Viveckh#107 from Viveckh/mgmt-attrib-update
86c02ee 
Fix Viveckh#106 Made changes to the UI for attributes modal not working
@Viveckh
Merge pull request Viveckh#108 from Viveckh/sock-node-fix
f96bf1b 
Fix: Viveckh#105 Sockjs fix
@smaharj1
deleting product after being paid
c0a24d3
@Viveckh
Merge pull request Viveckh#111 from Viveckh/product-deletion-paid
197c6b2 
FIX Viveckh#110: deleting product after being paid
@smaharj1
Order places wasn't being shown in admin cause there was no pagination
cc067f6 
- Added Pagination
- Tabs were somehow disappearing too. So, changed the logic there as well
@Viveckh
Merge pull request Viveckh#118 from Viveckh/fix/order-not-showing
28e8358 
Fix Viveckh#117: Order places not showing error
@smaharj1
Root cause of docker code change restart worker dying
9b7192a
@Viveckh
Merge pull request Viveckh#119 from Viveckh/worker-pandemic-fix
89df097 
Fix Viveckh#96: Worker dying after code changes
@smaharj1
Adding change log
c8f2011
@Viveckh
Merge pull request Viveckh#120 from Viveckh/changelog
da111e5 
Adding change log
@Viveckh
donate info added to readme (Viveckh#122)
1785092 
* donate info added to readme

* some spacing

* readme looked diff in github
@smaharj1
Fixed the two visual bugs
d65c8ae
@Viveckh
Merge pull request Viveckh#127 from Viveckh/fix/issue-126
67e0614 
Fix Viveckh#126 the two visual bugs in shopping client
@smaharj1
Button Fix
f511c61
@smaharj1
Changed the logger to reduce undefined stuff
526411f
@Viveckh
Merge pull request Viveckh#130 from Viveckh/ui-fix-128
186fc0a 
FIX Viveckh#128: Button Fix
@Viveckh
Merge pull request Viveckh#131 from Viveckh/logger-fix
a814314 
Changed the logger to reduce undefined stuff
@Viveckh
Create Funding.YML (Viveckh#135)
80feecf
@Viveckh
sendgrid email templates
f975769
@Viveckh
email setup documentation
db9c2aa
@Viveckh
Sendgrid temp (Viveckh#140)
f4045ce 
* sendgrid email templates

* email setup documentation
@Viveckh
s3 setup documentation
2c0a4df
@Viveckh
fixing mr conflict
71d92ce
@Viveckh
Merge pull request Viveckh#141 from Viveckh/sendgrid-temp
c5caf59 
S3 Setup doc
ssl settings documented
76f356f
updated references to server
7d7287d
Merge pull request Viveckh#142 from Viveckh/demo-servers-ssl
2c5593e 
SSL settings for servers and domains.
@Viveckh
migrate to atlas and patches
a620ad8
Viveckh and others added 15 commits December 9, 2020 22:34
@Viveckh
Merge pull request Viveckh#150 from Viveckh/migrate-to-atlas
9c29590 
migrate to atlas and patches
@Viveckh
updating the readme making it neat
7cac126
@Viveckh
fixing up the readme
f579d76
@Viveckh
sweet deal
0d0ae5e
@Viveckh
stuff is good
1567243
@Viveckh
looking neat documentation site
f6529ce
@Viveckh
another one here
f1ff357
Merge pull request Viveckh#156 from Viveckh/styling-readme
d8f16a2 
Readme and documentation site update with previews and other small changes.
@smaharj1
This logic reroutes the page to the last known page upon login
64f7b64
@smaharj1
Lint fixes
cbf7fea
@Viveckh
Merge pull request Viveckh#157 from Viveckh/re-route-upon-login
69cab8c 
Fix Viveckh#125 Reroutes the user to last known url upon login
@Viveckh
funding paypal link
191fd1e
Merge pull request Viveckh#161 from Viveckh/styling-readme
11fadc8 
funding paypal link
@gfyre
Complete Stripe 3D Secure Integration (Viveckh#158)
0bee6a8
@mhmdrameez
bug on Dockerfile-local
d4505d9 
 "Can't find Python executable "python""
VladCiocan
VladCiocan approved these changes Jul 16, 2023
View reviewed changes
Copy link

@VladCiocan VladCiocan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladCiocan VladCiocan VladCiocan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhmdrameez @VladCiocan @smaharj1 @Viveckh @gfyre