Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!] Breaking: Add more parameters to SitesManager.addSite #40

Merged
merged 1 commit into from
Nov 22, 2017
Merged

[!!!] Breaking: Add more parameters to SitesManager.addSite #40

merged 1 commit into from
Nov 22, 2017

Conversation

simonschaufi
Copy link
Contributor

Add settingValues and excludeUnknownUrls to addSite and sync them with the official Piwik API.
Beware of new parameter order!

@simonschaufi
Copy link
Contributor Author

phpunit/phpunit 6.4.4 requires php ^7.0 -> your PHP version (5.6.31) does not satisfy that requirement.

Should I downgrade phpunit again?

@thelfensdrfer
Copy link
Member

Thanks for your work! You can add php >= 7 as a requirement in the composer.json file. Should be fine. I will create a new minor release for this pull request anyways.

@simonschaufi
Copy link
Contributor Author

simonschaufi commented Nov 21, 2017

done.
HHVM still breaks. See also this issue: composer/composer#4976
Anyway, I have added it to the allow_failures list.

Btw, how did you create your avatar?

Add settingValues and excludeUnknownUrls to addSite and sync them with the official Piwik API.
Beware of new parameter order!
@thelfensdrfer thelfensdrfer merged commit 3fea023 into VisualAppeal:master Nov 22, 2017
@thelfensdrfer
Copy link
Member

I've used avatarmaker.com or some similar service ;)

@simonschaufi simonschaufi deleted the addSite branch November 22, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants