Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dex module inconsistencies #2069

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix dex module inconsistencies #2069

merged 2 commits into from
May 2, 2024

Commits on Apr 30, 2024

  1. fix signature and magic strings in dex module 

    Several bytestring values in the dex module were not set properly,
and were cut short due to the presence of a nul byte.

This happened on:
- all the dex.DEX_FILE_MAGIC_* constants, which were cut short by one
  byte (the last one is the nul byte).
- the magic and signature field in the "header" object of the module.

For all of those, the size is fixed and known, so use the right length
and do not cut it short if a nul byte is present.
    @vthib
    vthib committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b4072f6 View commit details
    Browse the repository at this point in the history

  2. fix declared fields in the dex module 

    There was some mismatch between the declared fields and the ones filled
by the module:

- `dex.field[*].static` and `dex.field[*].instance` were defined, but
  not declared, making their use impossible. They are now properly
  declared.

- several fields in `dex.method[*].code_item` were declared but never
  defined: `padding`, `tries` and `handlers`. Those are removed since
  they couldn't have been used.
    @vthib
    vthib committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cff2fcd View commit details
    Browse the repository at this point in the history