Skip to content

Commit

Permalink
Supercedes Quiet infer by default #178 PR (#179)
Browse files Browse the repository at this point in the history
* Both of these INFO: sections have the nature of debugging prints for
type inference.  Rather than default to this being noisy, default to
quiet but allow users to `-d=ggPlotDebugTypeInfer` to be verbose.

---------

Co-authored-by: Vindaar <basti90@gmail.com>
  • Loading branch information
c-blake and Vindaar committed May 6, 2024
1 parent fcf3c11 commit 272c3ef
Showing 1 changed file with 22 additions and 17 deletions.
39 changes: 22 additions & 17 deletions src/ggplotnim/collect_and_fill.nim
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import datamancer
import ginger except Scale

const StartHue {.intdefine.} = 15
const ggPlotDebugTypeInfer {.booldefine.} = false

proc addIdentityData(data: var Column, df: DataFrame, s: Scale) =
case s.col.kind
Expand Down Expand Up @@ -55,18 +56,20 @@ proc isDiscreteData(col: Column, s: Scale, drawSamples: static bool = true,
let elements = indices.mapIt(col[it, int]).toHashSet
if elements.card > (indices.len.float * discreteThreshold).round.int:
result = false
echo "INFO: The integer column `", $s.col, "` has been automatically ",
"determined to be continuous. To overwrite this behavior add a ",
"`+ scale_x/y_discrete()` call to the plotting chain. Choose `x`",
" or `y` depending on which axis this column refers to. Or apply a",
" `factor` to the column name in the `aes` call, i.e.",
" `aes(..., factor(\"" & $s.col & "\"), ...)`."
when ggPlotDebugTypeInfer:
echo "INFO: The integer column `", $s.col, "` has been automatically ",
"determined to be continuous. To overwrite this behavior add a ",
"`+ scale_x/y_discrete()` call to the plotting chain. Choose `x`",
" or `y` depending on which axis this column refers to. Or apply a",
" `factor` to the column name in the `aes` call, i.e.",
" `aes(..., factor(\"" & $s.col & "\"), ...)`."
else:
result = true
echo "INFO: The integer column `", $s.col, "` has been automatically ",
"determined to be discrete. To overwrite this behavior add a ",
"`+ scale_x/y_continuous()` call to the plotting chain. Choose `x`",
" or `y` depending on which axis this column refers to."
when ggPlotDebugTypeInfer:
echo "INFO: The integer column `", $s.col, "` has been automatically ",
"determined to be discrete. To overwrite this behavior add a ",
"`+ scale_x/y_continuous()` call to the plotting chain. Choose `x`",
" or `y` depending on which axis this column refers to."
of colFloat:
result = false
of colString:
Expand Down Expand Up @@ -100,15 +103,17 @@ proc isDiscreteData(col: Column, s: Scale, drawSamples: static bool = true,
discreteObjectCol = true
if not discreteObjectCol:
result = false
echo "INFO: The object column `", $s.col, "` has been automatically ",
"determined to be continuous. To overwrite this behavior use ",
"`scale_x/y_discrete` or apply `factor` to the column name in the `aes` ",
"call."
when ggPlotDebugTypeInfer:
echo "INFO: The object column `", $s.col, "` has been automatically ",
"determined to be continuous. To overwrite this behavior use ",
"`scale_x/y_discrete` or apply `factor` to the column name in the `aes` ",
"call."
else:
result = true
echo "INFO: The object column `", $s.col, "` has been automatically ",
"determined to be discrete. To overwrite this behavior use ",
"`scale_x/y_continuous`."
when ggPlotDebugTypeInfer:
echo "INFO: The object column `", $s.col, "` has been automatically ",
"determined to be discrete. To overwrite this behavior use ",
"`scale_x/y_continuous`."
of colNone:
raise newException(ValueError, "Input column " & $s.col & " is empty. Such a column " &
"cannot be plotted.")
Expand Down

0 comments on commit 272c3ef

Please sign in to comment.