Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][15.0] to_backend_theme: Fix pad UI goes wrong #21

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[FIX][15.0] to_backend_theme: Fix pad UI goes wrong #21

wants to merge 1 commit into from

Conversation

Ngquang
Copy link

@Ngquang Ngquang commented Jul 11, 2022 •
edited

Ticket: https://viindoo.com/web#cids=1&id=7192&model=helpdesk.ticket

-Hiện tại khi mở Note trên Chrome sẽ bị gặp lỗi hiển thị phần edit của pad bị co vào quá nhiều dẫn đến người dùng không thể nhìn được nội dung khi edit
Before

Screenshot from 2022-07-11 13-34-05

Nhưng tình trạng này lại không bị khi mở bằng Firefox, Safari.

Việc này có được đề cập tại đây: https://bugs.chromium.org/p/chromium/issues/detail?id=428049#c11

Gecko is always resolving percentages regardless of the flex-basis.
Chrome is never resolving percentages, regardless of the flex-basis.

Chrome và Firefox không cùng engine nên việc render flex-basis sẽ dẫn đến khác nhau.

Để xử lí vấn đề này, PR này sẽ gắn giá trị tuyệt đối cho flex-parent và các flex-container nằm trong flex-parent sẽ cần có thêm display:flex, flex:1 để chúng có thể co dãn cùng với kích thước của flex-parent.

After

Screenshot from 2022-07-11 13-33-20

PR này sẽ chỉ fix cho repo của mình mà không fix cho Odoo vì từ bản 16 Odoo đã bỏ pad:

  • https://github.com/odoo/odoo/pull/75768 : PR này Odoo cải tiến cho edit collab ở bất kỳ chỗ nào có html field
  • https://github.com/odoo/odoo/pull/76467 : PR này Odoo xoá pad

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed 🚀 Queue PR/Commit is added in build queue labels Jul 11, 2022
@Ngquang Ngquang force-pushed the v15_imp_to_backend_theme_2 branch from 8ceb917 to a898024 Compare July 11, 2022 07:31
@Ngquang Ngquang changed the title [FIX][15.0] to_backend_theme: Fix Chrome not filling percentage% height of flex parent [FIX][15.0] to_backend_theme: Fix pad UI goes wrong Jul 11, 2022
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed 🚀 Building PR/Commit is start building all step in script 🚀 Queue PR/Commit is added in build queue labels Jul 11, 2022
@Ngquang Ngquang force-pushed the v15_imp_to_backend_theme_2 branch from a898024 to 9cd5fc0 Compare July 11, 2022 09:05
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed 🚀 Building PR/Commit is start building all step in script 🚀 Queue PR/Commit is added in build queue labels Jul 11, 2022
@Ngquang Ngquang force-pushed the v15_imp_to_backend_theme_2 branch from 9cd5fc0 to de3f03b Compare July 11, 2022 10:03
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed 🚀 Building PR/Commit is start building all step in script labels Jul 11, 2022
@Ngquang
[FIX]to_backend_theme: Fix pad UI goes wrong
72eafbb 
- Currently in Chrome, parent-flex not having a true value so when
flex-basis apply, the child don't know what size to compute when size of
parent changed. It makes the editor shrink to much and user can not use
this editor
This PR will fix this problem.
@Ngquang Ngquang force-pushed the v15_imp_to_backend_theme_2 branch from de3f03b to 72eafbb Compare July 11, 2022 10:05
@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jul 11, 2022
@Ngquang
Copy link
Author

Ngquang commented Jul 12, 2022

@royleviindoo anh ơi, anh xem qua giúp em PR này với ạ.

@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚩 Done PR/Commit is finished manually test and closed instance labels Jul 18, 2022
@viinbot viinbot removed the 🚀 Running PR/Commit is done for everything and ready for manually test label Jul 31, 2022
@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed ⚠️ Failed PR/Commit is failed when run script labels Aug 8, 2022
@Ngquang Ngquang changed the title [FIX][15.0] to_backend_theme: Fix pad UI goes wrong [WIP][FIX][15.0] to_backend_theme: Fix pad UI goes wrong Aug 10, 2022
@viinbot viinbot removed the 🚀 Building PR/Commit is start building all step in script label Aug 10, 2022
@Ngquang Ngquang changed the title [WIP][FIX][15.0] to_backend_theme: Fix pad UI goes wrong [FIX][15.0] to_backend_theme: Fix pad UI goes wrong Aug 10, 2022
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Queue PR/Commit is added in build queue ⚠️ Failed PR/Commit is failed when run script labels Aug 10, 2022
@Ngquang Ngquang changed the title [FIX][15.0] to_backend_theme: Fix pad UI goes wrong [WIP][FIX][15.0] to_backend_theme: Fix pad UI goes wrong Aug 11, 2022
@viinbot viinbot removed the 🚀 Building PR/Commit is start building all step in script label Aug 11, 2022
@Ngquang Ngquang changed the title [WIP][FIX][15.0] to_backend_theme: Fix pad UI goes wrong [FIX][15.0] to_backend_theme: Fix pad UI goes wrong Aug 11, 2022
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Aug 11, 2022
@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚩 Done PR/Commit is finished manually test and closed instance labels Aug 18, 2022
@Ngquang
Copy link
Author

Ngquang commented Dec 17, 2022

Close PR do không còn bị gặp lại hiện tượng này

@Ngquang Ngquang closed this Dec 17, 2022
@Ngquang Ngquang deleted the v15_imp_to_backend_theme_2 branch December 17, 2022 04:29
@Ngquang Ngquang restored the v15_imp_to_backend_theme_2 branch December 17, 2022 04:34
@Ngquang Ngquang reopened this Dec 17, 2022
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royle-viindoo royle-viindoo Awaiting requested review from royle-viindoo

Assignees
No one assigned
Labels
🚀 Queue PR/Commit is added in build queue
Projects
None yet
Milestone
No milestone
2 participants
@Ngquang @viinbot