Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise the Swift version of Vexilla Client #42

Merged
merged 8 commits into from Mar 17, 2024
Merged

Optimise the Swift version of Vexilla Client #42

merged 8 commits into from Mar 17, 2024

Commits on Mar 14, 2024

  1. Move SwiftPM Package manifest to the git root, as this is required fo… 

    …r depending on this package
    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    acf5029 View commit details
    Browse the repository at this point in the history

  2. Recommend SSWG plugin for Swift

    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    ff53359 View commit details
    Browse the repository at this point in the history

  3. Remove repetition of API call code in the unit tests

    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    814958e View commit details
    Browse the repository at this point in the history

  4. Leverage XCTAssert comparison functions

    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    e3450c3 View commit details
    Browse the repository at this point in the history

  5. Optimise character hashing slightly, while also supporting unicode

    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    9932308 View commit details
    Browse the repository at this point in the history

  6. Add some error types

    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    1ff2b91 View commit details
    Browse the repository at this point in the history

  7. Unwind safeGet accessors, and add error messages in the process 

    Since safeGet is not used, we can add custom error messages that clarify the specific issue at hand. Also by leveraging `#function` you can trace back the origin of the error. Note: String errors should still be migrated over to concrete types.
This commit also adopts `guard let` syntax to keep cyclomatic complexity low.
    @Joannis
    Joannis committed Mar 14, 2024
    Copy the full SHA
    911f59d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Remove the existential any marker before Decoder since it's a mor… 

    …e recent Swift token
    @Joannis
    Joannis committed Mar 16, 2024
    Copy the full SHA
    3381137 View commit details
    Browse the repository at this point in the history