SYB-019 - Implement experimental API to trace functions without decorators #35
Conversation
| import Sibyl.Events, only: [define_event: 1] | ||
| import Sibyl.Experimental | ||
|
|
||
| import Kernel, except: [def: 2] |
There was a problem hiding this comment.
TODO: do we want to support tracing private functions?
There was a problem hiding this comment.
IMO it would be cool for it to be configurable to wrap any function-like definitions in traces, e.g. I might want to trace tests for them to appear later in my observability stack:
use Sibyl.Experimental, trace_all: [def: 2, defp: 2, test: 3]There was a problem hiding this comment.
That's a really fun idea actually, I'll look into how easily we can do that!
| 1) In order to trace functions, you must annotate functions with `@sibyl trace: true`. In future, we may be able to | ||
| capture extra metadata to attach to traces via additional keyword parameters. |
There was a problem hiding this comment.
The main reason we're doing this is not to conflict with anyone actually using the decorator library in their application.
Happy to take any opinions on what this annotation could be? I suppose if we want to extend this out as a generic decorator library alternative, we could go forward with @annotate?
This PR implements a new
Sibyl.Experimentalmodule which aims to replace the usage of thedecoratorlibrary we're currently using to avoid some of the pitfalls of said library.See the module docs in
Sibyl.Experimentalfor more info.Linked to #29