Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC-9883 - Support opentelemetry_process_propagator 0.2 #28

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

rob-vetspire
Copy link

@rob-vetspire rob-vetspire commented Aug 4, 2023

Require opentelemetry_process_propagator "~> 0.1.0 or ~> 0.2.0".

This allows users of Absinthe to upgrade to 1.7, as:

Because sibyl >= 0.1.3 depends on opentelemetry_process_propagator ~> 0.1.0 and 
absinthe >= 1.7.2 depends on opentelemetry_process_propagator ~> 0.2.1, 
sibyl >= 0.1.3 is incompatible with absinthe >= 1.7.2.

And because your app depends on absinthe ~> 1.7.5, sibyl >= 0.1.3 is forbidden.
So, because your app depends on sibyl ~> 0.1.8, version solving failed.

@rob-vetspire rob-vetspire changed the title Support opentelemetry_process_propagator 0.2 VC-9883 - Support opentelemetry_process_propagator 0.2 Sep 29, 2023
Copy link
Collaborator

@vereis vereis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test before merging, thanks!

@vereis vereis merged commit 2c9de65 into main Oct 23, 2023
1 check passed
@vereis vereis deleted the support-opentelemetry_process_propagator-0.2 branch October 23, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants