Uninformative updateidentity error message

[Alrighttt]

Describe the issue

updateidentity rpc command can fail with an unhelpful error message if the wallet does not own the necessary keys.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

1. do updateidentity on an identity the node does not have the necessary keys to redefine
   eg, :

./verus -chain=VRSCTEST updateidentity '{"name":"mac","primaryaddresses":["RMM5MvWYndvZimgby8SWvfzWFHiGJM6hBd"],"minimumsignatures":1, "parent":"vrsctest"}'

Expected behaviour

It should display an error message explaining the issue, and how to remedy it.

Actual behaviour + errors

A debug print is printed to stdout while doing this:

Failed to sign for script:
{
  "txid": "102e9b0843368664df11a0c64b847e6f63410c94ee59a63e32ce7b252bce1ea1",
  "version": 4,
  "locktime": 0,
  "vin": [
   {
    "txid": "c6cc5016aeb1ecbcba7818de53b5d055c771c54f3f689c2a2f6ee6c0a0668dd8",
    "vout": 0,
    "scriptSig": {
     "asm": "",
     "hex": ""
    },
    "sequence": 4294967295
   },
   {
    "txid": "c69c13ecf723f54d06cf4a7e3fbfe0c08e41a9302ae6a4c748b00cc9e9414e94",
    "vout": 2,
    "scriptSig": {
     "asm": "",
     "hex": ""
    },
    "sequence": 4294967295
   }
  ],
  "vout": [
   {
    "value": 0.00,
    "n": 0,
    "scriptPubKey": {
     "type": "cryptocondition",
     "identityprimary": {
      "version": 3,
      "flags": 0,
      "primaryaddresses": [
       "RMM5MvWYndvZimgby8SWvfzWFHiGJM6hBd"
      ],
      "minimumsignatures": 1,
      "name": "nn",
      "identityaddress": "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta",
      "parent": "iJhCezBExJHvtyH3fGhNnt2NhU4Ztkf2yq",
      "systemid": "iJhCezBExJHvtyH3fGhNnt2NhU4Ztkf2yq",
      "contentmap": {
      },
      "contentmultimap": {
      },
      "revocationauthority": "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta",
      "recoveryauthority": "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta",
      "timelock": 0
     },
     "spendableoutput": false,
     "reqSigs": 1,
     "addresses": [
      "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta",
      "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta",
      "iE8XS9SNGsXTBzJ9xuLfM8xvpmP5KSHuta"
     ],
     "hex": "470403000103150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093cc4cd104030e0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70934c7c03000000000000000114845d90eb188680eb3d0c88f58ba4174281d09cdd01000000a6ef9ea235635e328124ff3429db9f9e91b64e2d026e6e000074e110bd30c66a52e5354bb7b2ccbf2de74c709374e110bd30c66a52e5354bb7b2ccbf2de74c709300a6ef9ea235635e328124ff3429db9f9e91b64e2d000000001b04030f0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70931b0403100101150474e110bd30c66a52e5354bb7b2ccbf2de74c709375"
    }
   },
   {
    "value": 0.9998,
    "n": 1,
    "scriptPubKey": {
     "type": "pubkeyhash",
     "spendableoutput": true,
     "reqSigs": 1,
     "addresses": [
      "RAF8AFLEGi68CiLj4kdgVjdpW1sRcrLv24"
     ],
     "hex": "76a9140a9405decd150b30903137eb286da1a385c3a7e288ac"
    }
   }
  ],
  "hex": "0400008085202f8902d88d66a0c0e66e2f2a9c683f4fc571c755d0b553de1878babcecb1ae1650ccc60000000000ffffffff944e41e9c90cb048c7a4e62a30a9418ec0e0bf3f7e4acf064df523f7ec139cc60200000000ffffffff020000000000000000fd1d01470403000103150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093cc4cd104030e0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70934c7c03000000000000000114845d90eb188680eb3d0c88f58ba4174281d09cdd01000000a6ef9ea235635e328124ff3429db9f9e91b64e2d026e6e000074e110bd30c66a52e5354bb7b2ccbf2de74c709374e110bd30c66a52e5354bb7b2ccbf2de74c709300a6ef9ea235635e328124ff3429db9f9e91b64e2d000000001b04030f0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70931b0403100101150474e110bd30c66a52e5354bb7b2ccbf2de74c709375e092f505000000001976a9140a9405decd150b30903137eb286da1a385c3a7e288ac00000000970000000000000000000000000000"
 }

The response given from cli:

./verus -chain=VRSCTEST updateidentity '{"name":"nn","primaryaddresses":["RMM5MvWYndvZimgby8SWvfzWFHiGJM6hBd"],"minimumsignatures":1, "parent":"vrsctest"}'
error code: -4
error message:
0400008085202f8902d88d66a0c0e66e2f2a9c683f4fc571c755d0b553de1878babcecb1ae1650ccc60000000000ffffffff944e41e9c90cb048c7a4e62a30a9418ec0e0bf3f7e4acf064df523f7ec139cc6020000006a4730440220760d8d38feaeb6ddd3e5ec7fbf49edc5d2c3ddf6d6945b669802d0aa3ae23d7502206db08b1c008a7dfd60dd0ed1359a1510fd35279d230a695179c5b02ef7103f32012102f6af3f3c85b16ab0695b0f2bcf19ac7ccf6c7378110ad020448abbd54a75c5d5ffffffff020000000000000000fd1d01470403000103150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093150474e110bd30c66a52e5354bb7b2ccbf2de74c7093cc4cd104030e0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70934c7c03000000000000000114845d90eb188680eb3d0c88f58ba4174281d09cdd01000000a6ef9ea235635e328124ff3429db9f9e91b64e2d026e6e000074e110bd30c66a52e5354bb7b2ccbf2de74c709374e110bd30c66a52e5354bb7b2ccbf2de74c709300a6ef9ea235635e328124ff3429db9f9e91b64e2d000000001b04030f0101150474e110bd30c66a52e5354bb7b2ccbf2de74c70931b0403100101150474e110bd30c66a52e5354bb7b2ccbf2de74c709375e092f505000000001976a9140a9405decd150b30903137eb286da1a385c3a7e288ac00000000970000000000000000000000000000

The version of Verusd you were using:

Verus Daemon version 0.9.9-5

Machine specs:

• ubuntu 20.04 and macOS Ventura 13.3.1