Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] LargeProfileAvatars #1976

Closed
wants to merge 9 commits into from
Closed

[Plugin] LargeProfileAvatars #1976

wants to merge 9 commits into from

Conversation

BoardTM
Copy link
Sponsor Contributor

@BoardTM BoardTM commented Nov 11, 2023

Makes avatars take up the full width of the profile modal and renders them in higher resolution.
before
after

Copy link
Contributor

@ant0n-0x0000 ant0n-0x0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a good idea to add css fallbacks incase discord update UI but that's up to you.

src/plugins/largeProfileAvatars/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ant0n-0x0000 ant0n-0x0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also, add a README.md for your plugin!

Co-authored-by: ant0n <antonickadoo@gmail.com>
@MrDiamondDog
Copy link
Contributor

This can be done with css

@BoardTM
Copy link
Sponsor Contributor Author

BoardTM commented Nov 12, 2023

This can be done with css

Correct me if I’m wrong, but css will not be able to change the resolution of the avatar which is why this is a plugin and not just a theme.

@MrDiamondDog
Copy link
Contributor

I don't think you can change the resolution but most pfps are high enough resolution already, either way this doesn't feel like it should be a whole plugin

@BoardTM
Copy link
Sponsor Contributor Author

BoardTM commented Nov 12, 2023

Discord only grabs the picture in 80x80px by default this plugin makes it user selectable.

@BoardTM
Copy link
Sponsor Contributor Author

BoardTM commented Nov 13, 2023

Turns out the patch is kinda flawed so I’m closing this so I can rework it.

@BoardTM BoardTM closed this Nov 13, 2023
@BoardTM
Copy link
Sponsor Contributor Author

BoardTM commented Nov 13, 2023

Completely rewrote the patch such that it no longer touches chat avatars

@BoardTM BoardTM reopened this Nov 13, 2023
@Vendicated
Copy link
Owner

honestly the way this looks is kinda ugly. might be better to have it in larger size here instead and push the rest down?
image

alternatively, and especially considering this plugin mostly consists of css, you could instead just define a larger pfp link as a data attribute on the pfp node and leave the rest of the work to themes / quick css? this way a theme could do something like the following and then adjust the ui accordingly

.avatar {
	content: attr(large-avatar-url);
}

this could be part of the ThemeAttributes plugin

let me know your thoughts! (and sorry for taking so long to get to this)

@BoardTM
Copy link
Sponsor Contributor Author

BoardTM commented May 12, 2024

alternatively, and especially considering this plugin mostly consists of css, you could instead just define a larger pfp link as a data attribute on the pfp node and leave the rest of the work to themes / quick css? this way a theme could do something like the following and then adjust the ui accordingly

.avatar {
	content: attr(large-avatar-url);
}

this could be part of the ThemeAttributes plugin

let me know your thoughts! (and sorry for taking so long to get to this)

I like this idea, would probably need a completely new patch since it would probably be better to try to add it to all avatarstack elements so that it could be used in more places. I'll keep this PR open for the time being (if that's alright) but I assume it would be better to open a new one for the addition to ThemeAttributes.

@Vendicated
Copy link
Owner

Vendicated commented May 14, 2024

assuming this can be closed now as superseded by #2449?

@Vendicated Vendicated closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants