Bugfix: specify monospace font explicitly. #3259 #3260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enviroment
Test(Google Chrome)
Test(Microsoft Edge)
|
fukusuket
changed the title
scudette
reviewed
Feb 1, 2024
| @@ -141,6 +141,10 @@ body.ncurses { | |||
| font-size: var(--font-size-base) !important; | |||
| } | |||
|
|
|||
| .ncurses .ace_editor, .ace_editor * { | |||
There was a problem hiding this comment.
Probably we dont want to add to this file since this is only for the ncurses theme.
The font family is already set in the theme file for example
We actually include fonts already so the browser should not need to fall back to system fonts at all.
Can you please check if you see the same problem in all themes and then use the dev console to check what font is actually loaded at the position of the caret?
|
This issue is now fixed in #3262 so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Create a new artifacteditor in Chrome(on macOS) #3259Evidence
Enviroment
Test(Google Chrome)
I run the steps to reproduce #3259 and confirmed that the issue was resolved as follows.
Test(Firefox)
Test(Safari)
Thank you for your time.
Best,