Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiHopRAG dataset #4

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add MultiHopRAG dataset #4

wants to merge 1 commit into from

Conversation

XkunW
Copy link
Collaborator

@XkunW XkunW commented May 6, 2024

PR Type

[Feature]

Short Description

Added MultiHopRAG dataset

@XkunW XkunW requested a review from xeon27 May 6, 2024 16:15
@xeon27
Copy link
Collaborator

xeon27 commented May 6, 2024

@XkunW How did you create the doc_store? Were you not required to make any changes to the _create_doc_store function?

@XkunW
Copy link
Collaborator Author

XkunW commented May 6, 2024

@XkunW How did you create the doc_store? Were you not required to make any changes to the _create_doc_store function?

I missed the _create_doc_store function when I first started adding this dataset, and I just wrote a small function to create the doc store, but I didn't include that in the commit

@xeon27
Copy link
Collaborator

xeon27 commented May 6, 2024

@XkunW How did you create the doc_store? Were you not required to make any changes to the _create_doc_store function?

I missed the _create_doc_store function when I first started adding this dataset, and I just wrote a small function to create the doc store, but I didn't include that in the commit

Can you check if that code can be integrated in the _create_doc_store function? I think it would be helpful in tracking the source of the doc_store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants