Fire an advancement trigger when reading a book #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealWormbo
force-pushed
the
1.20-reading-advancement-trigger
branch
from
3e9f6ea
to
f45a1c2
Compare
|
This PR has been tested using the following Botania code changes: TheRealWormbo/Botania@2c40fe8 |
|
The 1.20.1 version of this PR is archived at https://github.com/TheRealWormbo/Patchouli/tree/1.20.1-reading-advancement-trigger, in case that version of Patchouli still receives updates. The following update to this PR is for 1.20.4, but lacking a corresponding Botania version, it could not be tested thoroughly. |
TheRealWormbo
force-pushed
the
1.20-reading-advancement-trigger
branch
from
f45a1c2
to
1ba70b0
Compare
TheRealWormbo
force-pushed
the
1.20-reading-advancement-trigger
branch
from
1ba70b0
to
6bb02d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger condition uses the book's resource location, and optionally a specific entry resource location and page number. However, the latter are only triggered by server code opening the book at that entry and page, not by the player going there via interactions with the opened book.