Circular Drive is attached to hand similar to Linear Drive #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, this must be merged into master. I have to come back to this pull request every time I create a project or update the plugin 🤒 PS: It will make a year anniversary soon 🎈 |
|
Breaking in SteamVR Unity Plugin - v2.5 (sdk 1.8.19) Assets\SteamVR\InteractionSystem\Core\Scripts\CircularDrive.cs(275,65): error CS0103: The name 'attachmentFlags' does not exist in the current context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circular Drive, Linear Drive and Throwable all allow a player to move an object. Only Circular Drive was not attached to the hand on a grab. This change allows you to use the features of the Interactable script, as "Hide hand on attach" for the Circular Drive too.
The outAngle of Circular Drive could be updated outside of the class, as it was a public variable. The variable is now private and a property was added to allow you to still change the outAngle, but now it also updates the gameObject.
This is my first pull request, so I hope I did this right!