Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for vcpkg submodule at top level CmakeLists.txt #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Look for vcpkg submodule at top level CmakeLists.txt #255

wants to merge 1 commit into from

Conversation

ShyAssassin
Copy link

No description provided.

@zpostfacto
Copy link
Contributor

Thanks for this PR.
Sorry it's taken me so long to look at it.....
Can you explain this change a bit more?

@ShyAssassin
Copy link
Author

Sure!
When using this library as a submodule cmake looks for vcpkg relative to the path of the library this is a problem because vcpkg inst shipped with the library itself.
this PR changes that so cmake looks for vcpkg at the "top most" invoking CMakeLists.txt where vcpkg is most likely located

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShyAssassin @zpostfacto