Implement normal command #8896
Implement normal command #8896
Conversation
src/transformations/execute.ts
Outdated
| for (const line of resultLines) { | ||
| vimState.cursorStopPosition = vimState.cursorStartPosition = | ||
| TextEditor.getFirstNonWhitespaceCharOnLine(vimState.document, line.lineNumber); | ||
| await modeHandler.handleMultipleKeyEvents(keystroke.value); |
There was a problem hiding this comment.
Is it possible to call rerunRecordedState from the second line？
There was a problem hiding this comment.
do you mean that dot command is working properly or not?
actually :normal . is doing well..
|
|
||
| override async execute(vimState: VimState): Promise<void> { | ||
| const keystroke = this.keystroke; | ||
| vimState.recordedState.transformer.addTransformation({ |
There was a problem hiding this comment.
set start/end line number to vimState.cursorStopPosition, the logic in executeNormal will be clearer
There was a problem hiding this comment.
I think that not setting start/end is better, because normal command behavior with visual and normal mode are different.
for example,
- text:
aaaaa - start position: end of line
- command:
:normal iX
executing above with visual mode, the result is Xaaaaa.
but with normal mode, it is aaaaaX.
to achive the difference, executeTransformations checks setting start/end or not.
withRange stores it as boolean.
if (withRange) {
vimState.cursorStopPosition = vimState.cursorStartPosition =
TextEditor.getFirstNonWhitespaceCharOnLine(vimState.document, line.lineNumber);
}
await modeHandler.handleMultipleKeyEvents(keystroke.value);
await vimState.setCurrentMode(Mode.Normal);
@feeiyu
if you have better idea, please tell me..
There was a problem hiding this comment.
Can we replace startLineNumber/endLineNumber/withRange with this?
range?: LineRange,
|
I implemented test codes. |
|
@J-Fields |
| public static readonly argParser: Parser<NormalCommand> = seq(whitespace, all).map( | ||
| ([_, keystroke]) => new NormalCommand(keystroke), |
There was a problem hiding this comment.
This would be a bit nicer as:
whitespace.then(all).map(...);
| const resultLineNumbers: number[] = []; | ||
| if (withRange) { | ||
| for (let i = startLineNumber; i <= endLineNumber; i++) { | ||
| resultLineNumbers.push(vimState.document.lineAt(i).lineNumber); |
There was a problem hiding this comment.
| resultLineNumbers.push(vimState.document.lineAt(i).lineNumber); | |
| resultLineNumbers.push(i); |
| const { start, end } = selection; | ||
|
|
||
| for (let i = start.line; i <= end.line; i++) { | ||
| resultLineNumbers.push(vimState.document.lineAt(i).lineNumber); |
There was a problem hiding this comment.
| resultLineNumbers.push(vimState.document.lineAt(i).lineNumber); | |
| resultLineNumbers.push(i); |
| } | ||
| await modeHandler.handleMultipleKeyEvents(stroke.value); | ||
| if (vimState.currentMode === Mode.Insert) { | ||
| await modeHandler.handleMultipleKeyEvents(['<Esc>']); |
There was a problem hiding this comment.
| await modeHandler.handleMultipleKeyEvents(['<Esc>']); | |
| await modeHandler.handleKeyEvent('<Esc>'); |
| @@ -186,6 +186,14 @@ export interface ContentChangeTransformation { | |||
| diff: PositionDiff; | |||
| } | |||
|
|
|||
| export interface ExecuteNormalTransformation { | |||
| type: 'executeNormal'; | |||
| keystroke: string; | |||
There was a problem hiding this comment.
Shouldn't this be called keystrokes? (as well as NormalCommand.keystrokes?)
What this PR does / why we need it:
Which issue(s) this PR fixes
Special notes for your reviewer
it is designed referring to macro implementation.