Revert "Switch to using std::jthread." #1065
Draft
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02eb40b.
Signed-off-by: Rui Chen <rui@chenrui.dev>
nilsnolde
reviewed
Jan 18, 2024
| @@ -9,7 +9,7 @@ Copyright (c) 2015-2024, Julien Coupey. | |||
| All rights reserved (see LICENSE). | |||
|
|
|||
| */ | |||
| #include "../include/rapidjson/include/rapidjson/document.h" | |||
| #include "<rapidjson/document.h>" | |||
There was a problem hiding this comment.
couldn't this be worked around in vroom with a make flag to optionally add -I ../include/rapidjson/include and keep this instead, so people/package builders can use system packages if they want to?
There was a problem hiding this comment.
though not sure about rapidjson in particular which didn't release in a decade or so..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR just to unblock my homebrew PR, no intention to get this merge yet.
relates to #1062
relates to Homebrew/homebrew-core#160054