Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Add minimum requirements for package installation #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add minimum requirements for package installation #103

wants to merge 1 commit into from

Conversation

gbeckenkamp
Copy link

No description provided.

@gbeckenkamp
Add cython and setuptools as minimum requirements to make sure a that…
a2614d3 
… a clean environment can install the package
@gbeckenkamp gbeckenkamp mentioned this pull request Nov 25, 2022
Open
cdeln
cdeln approved these changes Dec 6, 2022
View reviewed changes
Copy link

@cdeln cdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out in fresh virtual env with python 3.8.
This solves downstream package consumers using pip with --use-pep517 flag (default when using tools such as poetry).

@miguelvalente
Copy link

Tried it out in fresh virtual env with python 3.8. This solves downstream package consumers using pip with --use-pep517 flag (default when using tools such as poetry).

Hi guys. Having the same issue here. Any updates on the status of the merge?

@gbeckenkamp
Copy link
Author

Sorry guys I was away for a while.
I cannot merge due to: At least 1 approving review is required by reviewers with write access.

@Dominux
Copy link

Dominux commented Feb 18, 2023

Just yet another one greatly introduced package, that's "blazingly fast", but you can't just install it LMAO

vitalymegabyte added a commit to vitalymegabyte/YouTokenToMe that referenced this pull request Feb 28, 2023
@vitalymegabyte
do Pull Requerst with requirements
2c3268b 
VKCOM#103
@gburlet gburlet mentioned this pull request May 11, 2023
Open
@gburlet
Copy link

gburlet commented May 11, 2023

This PR has already fallen out of date.

Updated PR here: #108

adrianlzt added a commit to assistify-ai/YouTokenToMe that referenced this pull request Jan 8, 2024
@adrianlzt
Cython is required to build
028af85 
VKCOM#103
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yutkin yutkin yutkin approved these changes

@cdeln cdeln cdeln approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gbeckenkamp @miguelvalente @Dominux @gburlet @yutkin @cdeln