Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev compress #873

Merged
merged 44 commits into from Apr 17, 2024
Merged

Dev compress #873

merged 44 commits into from Apr 17, 2024

Conversation

mikedawson
Copy link
Member

Implementation of compression issue #750

Add UI for setting compression level on ContentEntryEdit on Compose.
Compression level was not being picked up from contententryimportjob and passed to
Allow the user to dismiss an error.
Implements show required extra info for user task (Issue #750)
Based on command line testing of video output results.
Issue #750 (desktop video compression)
Update comments on CompressVideoUseCaseJvmVlc to reflect the fact that it is currently unusable.
Handbrake settings updated to use quality setting instead of a constant bitrate. Add additional compression settings (highest and lowest).
1. Update developer documentation to reflect changed media dependencies.
2. Use path detection (instead of hardcoded path) for HandBrakeCLI
3. Add HandBrakeCLI to windows app-resources bundle
4. Update conveyor Linux package dependencies
5. Fix conveyor.conf dependencies for new Jetpack compose version
6. Add additional video mime types to MimeTypeHelper to ensure they are recognized.
1. Implement support for users with permission to cancel a content entry import job that is running on the server (e.g. file upload from web, or entry being imported from a url)
2. Add display of content entry import progress on app-react/JS version
Latest Ubuntu LTS HandBrake package does not support AV1.
1) Cypress test needs to wait for importing conversion to finish. Add wait to test. Change video to a shorter clip.
2) Fix VideoContentImporterCommonJvm to delete compressed temporary file.
1) Implement CompressAudioUseCaseAndroid. This uses Jetpack Media3 as Litr did not cooperate.
2) Improve CompressImageUseCaseAndroid. The compressor library was not considering the original image dimensions, so when an image was already smaller than the compression maximum size, it was actually being scaled up.
3) Make ExtractMediaMetadataUseCase multiplatform. Put in an Android implementation.
…stscript command is available.

Update CompressResult to include size before/after compression.
…obs will be able to track how much bandwidth is saved.
@mikedawson mikedawson merged commit 66e8a1d into primary Apr 17, 2024
@mikedawson mikedawson deleted the dev-compress branch April 17, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant