New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev compress #873
Merged
Merged
Dev compress #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncellation option)
Add UI for setting compression level on ContentEntryEdit on Compose.
Compression level was not being picked up from contententryimportjob and passed to
Allow the user to dismiss an error. Implements show required extra info for user task (Issue #750)
…e used by video compression on JVM).
Based on command line testing of video output results. Issue #750 (desktop video compression)
Update comments on CompressVideoUseCaseJvmVlc to reflect the fact that it is currently unusable.
VLC transcoding results were buggy.
Handbrake settings updated to use quality setting instead of a constant bitrate. Add additional compression settings (highest and lowest).
1. Update developer documentation to reflect changed media dependencies. 2. Use path detection (instead of hardcoded path) for HandBrakeCLI 3. Add HandBrakeCLI to windows app-resources bundle 4. Update conveyor Linux package dependencies 5. Fix conveyor.conf dependencies for new Jetpack compose version 6. Add additional video mime types to MimeTypeHelper to ensure they are recognized.
Update logging on App.kt exit.
…t are running on the server.
1. Implement support for users with permission to cancel a content entry import job that is running on the server (e.g. file upload from web, or entry being imported from a url) 2. Add display of content entry import progress on app-react/JS version
…g when file does not exist.
Latest Ubuntu LTS HandBrake package does not support AV1.
1) Cypress test needs to wait for importing conversion to finish. Add wait to test. Change video to a shorter clip. 2) Fix VideoContentImporterCommonJvm to delete compressed temporary file.
…ideo, audio, and images found.
1) Implement CompressAudioUseCaseAndroid. This uses Jetpack Media3 as Litr did not cooperate. 2) Improve CompressImageUseCaseAndroid. The compressor library was not considering the original image dimensions, so when an image was already smaller than the compression maximum size, it was actually being scaled up. 3) Make ExtractMediaMetadataUseCase multiplatform. Put in an Android implementation.
…the CompressImageUseCase interface.
…the CompressImageUseCase interface.
…stscript command is available. Update CompressResult to include size before/after compression.
…obs will be able to track how much bandwidth is saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of compression issue #750