Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JSONObject): Throw proper error if literal is not an object #2284

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

tjenkinson
Copy link
Contributor

@tjenkinson tjenkinson commented Mar 9, 2024

Description

This PR handles the literal for JSONObject not being an object and throws a proper error.

Related #2285

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

In my local project I copied the dist/esm dir into my node modules and verified the error is now correct.

It now looks like

"JSONObject cannot represent non-object value: \"test\""

instead of

"Expected value of type \"JSONObject\", found \"test\"; Cannot read properties of undefined (reading 'forEach')"

Test Environment:

  • OS: Mac
  • GraphQL Scalars Version: This commit
  • NodeJS: Cloudflare Wrangler

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tjenkinson tjenkinson marked this pull request as ready for review March 9, 2024 17:05
@ardatan ardatan changed the title JSONObject: Throw proper error if literal is not an object fix(JSONObject): Throw proper error if literal is not an object Mar 18, 2024
@ardatan ardatan merged commit fae46bb into Urigo:master Mar 18, 2024
8 checks passed
This was referenced Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants