Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scalars): add swedish personal number #2181

Merged

Conversation

blacksrc
Copy link
Contributor

@blacksrc blacksrc commented Dec 3, 2023

Description

Adds scalar for Swedish personal number. Also, can be a beginning for adding more formats for different countries.

Related #2180

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

Jest unit test with proper coverage.
image

Test Environment:

  • OS: Ubuntu 22.04.3 LTS
  • GraphQL Scalars Version: 1.22.4
  • NodeJS: v18.16.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@blacksrc
Copy link
Contributor Author

@ardatan Would appreciate if you could take a look.

@ardatan ardatan merged commit a868ecc into Urigo:master Mar 18, 2024
This was referenced Mar 18, 2024
Copy link

@circled9 circled9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I commented by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants