Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parse ObjectID scalar to Mongo ObjectID #2008

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pukuba
Copy link
Contributor

@pukuba pukuba commented Jul 1, 2023

Description

#429 Parse ObjectID scalar to Mongo ObjectID

Changed the type of ObjectID from string to BSON ObjectID
The code to generate ObjectID was taken from js-bson
After deploying this feature, the bundle size will increase by about 7kb

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Added test cases to compare with mongodb ObjectID

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant