Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vertexai embeddings #2693

Merged
merged 38 commits into from Mar 28, 2024
Merged

feat: add vertexai embeddings #2693

merged 38 commits into from Mar 28, 2024

Conversation

ahmetmeleq
Copy link
Contributor

@ahmetmeleq ahmetmeleq commented Mar 26, 2024

This PR:

  • Adds VertexAI embeddings as an embedding provider

Testing

  • Tested with pinecone destination connector on this job run.

@ahmetmeleq ahmetmeleq changed the title add vertexai with testing on pinecone feat: add vertexai embeddings Mar 26, 2024
@potter-potter
Copy link
Contributor

Looking good.
Did you want to include a ingest test for VertexAI like:
https://github.com/Unstructured-IO/unstructured/blob/main/test_unstructured_ingest/src/local-embed-bedrock.sh

And if you're feeling extra productive :) can you make one for Octoai???

Copy link
Contributor

@potter-potter potter-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@ahmetmeleq ahmetmeleq removed this pull request from the merge queue due to a manual request Mar 28, 2024
@ahmetmeleq ahmetmeleq added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit d467922 Mar 28, 2024
46 checks passed
@ahmetmeleq ahmetmeleq deleted the ahmet/vertex-embed branch March 28, 2024 21:48
kaaloo pushed a commit to inclusif/unstructured that referenced this pull request Apr 8, 2024
This PR:
- Adds VertexAI embeddings as an embedding provider

Testing
- Tested with pinecone destination connector on
[this](https://github.com/Unstructured-IO/unstructured/actions/runs/8429035114/job/23082700074?pr=2693)
job run.

---------

Co-authored-by: Matt Robinson <mrobinson@unstructuredai.io>
Co-authored-by: Matt Robinson <mrobinson@unstructured.io>
kaaloo pushed a commit to inclusif/unstructured that referenced this pull request Apr 8, 2024
This PR:
- Adds VertexAI embeddings as an embedding provider

Testing
- Tested with pinecone destination connector on
[this](https://github.com/Unstructured-IO/unstructured/actions/runs/8429035114/job/23082700074?pr=2693)
job run.

---------

Co-authored-by: Matt Robinson <mrobinson@unstructuredai.io>
Co-authored-by: Matt Robinson <mrobinson@unstructured.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants