Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Frozen bag warning when loading services after container is dumped #63

Merged
merged 1 commit into from Mar 14, 2024

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Mar 13, 2024

Description

Services were previously loaded every time a configuration was generated (including after the container was finished and cannot be modified), now it only loads services once.

Fixes #49

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

@RikudouSage RikudouSage merged commit 9180122 into main Mar 14, 2024
3 checks passed
@RikudouSage RikudouSage deleted the fix/frozen-bag-warning branch March 14, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Using bin/console cache:warmup gives warning of FrozenBag
2 participants