Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #59

Merged
merged 2 commits into from Mar 7, 2024
Merged

Update README.md #59

merged 2 commits into from Mar 7, 2024

Conversation

TomHart
Copy link
Contributor

@TomHart TomHart commented Feb 23, 2024

Description

Docs have the wrong bundle extension name

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Okhoshi
Copy link
Contributor

Okhoshi commented Feb 23, 2024

While you are at it, maybe you could also rename the TreeBuilder in the DependencyInjection/Configuration.php file, to match the new extension name :)

@TomHart
Copy link
Contributor Author

TomHart commented Feb 23, 2024

Good shout, done!

@thomasheartman
Copy link
Contributor

Hey! Sorry for the delay on this. This seems like a good fix to me, but I'm not familiar with this or the PHP SDK. That said, I'll trust the two of you that this is a good change, but I'd like to give @RikudouSage a chance (24 hours or so) to chime in before merging this. If I hear nothing, I'll merge it tomorrow morning.

Thanks for the contribution and sorry for the wait 😄

Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the delay.

@RikudouSage RikudouSage merged commit fc18275 into Unleash:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants