Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle playlist of internet radio stations #4572

Open
wants to merge 919 commits into
base: main
Choose a base branch
from

Conversation

ik666
Copy link
Contributor

@ik666 ik666 commented Apr 9, 2024

Added playlist support for handling internet radio stations. No transcoding yet (probably not neccesary for the usual codecs).

Feature can be tested with:

  • Generate Radio Browser playlist and copy it to a share (do not place to many radio stations inside playlist file, yet)

my_internet_radio_station.m3u file consists of radio stations like

#EXTM3U

#RADIOBROWSERUUID:962cc6df-0601-11e8-ae97-52543be04c81
#EXTINF:1,Dance Wave!
https://dancewave.online/dance.mp3
  • VLC navigating to VLC media player -> Universal Plug 'n Play -> UMS -> my_internet_radio_station.m3u -> radio

Netty 3 MediaServer implementation seems to have an issue serving large chunked streams and becomes more and more unresponsive over some time (a few seconds !).

JDK MediaServer implementation is much more responsive and stable over time. server_engine config entry should therefore be something like 1.

Todo :
[x] cache radio station metadata in a table
[-] currently for for a radio station 2 resources are created, one is VLC Web Audio (probably the renderer) and one is "no transcoding". Maybe this is only cosmetic and can stay this way.
[x] read metadata from radio browser API if possible
[-] adding support for hardware audio player (not in scope any more)

SurfaceS and others added 30 commits February 16, 2024 14:26
# Conflicts:
#	react-client/package.json
#	react-client/yarn.lock
* Bump MediaInfo to 24.01

* Bump MediaInfo to 24.01.1
# Conflicts:
#	react-client/package.json
#	react-client/yarn.lock
add advice how to register a TMDB API key.
# Conflicts:
#	react-client/package.json
#	react-client/yarn.lock
#	src/main/external-resources/documentation/index.html
# Conflicts:
#	pom.xml
# Conflicts:
#	react-client/package.json
#	react-client/yarn.lock
Bugfix of playback issues of composer / conductor
…sts_lc_name

Do not lowercase playlist name for display.
SurfaceS and others added 21 commits May 23, 2024 10:49
# Conflicts:
#	src/main/java/net/pms/store/MediaStore.java
…ist_title

show Playlists title without extension
# Conflicts:
#	CHANGELOG.md
# Conflicts:
#	CHANGELOG.md
Fixed NullPointerException on RendererFrame.buildEditBar
V14.1- Added Specials folder for TV Series
@SubJunk
Copy link
Member

SubJunk commented May 27, 2024

@dependabot recreate

@ik666 ik666 changed the base branch from main to v14.1 May 27, 2024 06:35
* v14.1: (98 commits)
  fix navbar
  Added Specials folder for TV Series
  Fixed NullPointerException on RendererFrame.buildEditBar
  partial fix for UniversalMediaServer#4691 lint
  Serie -> Series
  Post-release
  14.0.1
  Merge ums/main into v14.1
  Updated changelog
  check for range
  dc:title correction for playlists : suppress extension
  fix 4682 (UniversalMediaServer#4684)
  Bump video.js from 8.10.0 to 8.12.0 in /react-client (UniversalMediaServer#4677)
  Bump com.sun.xml.messaging.saaj:saaj-impl from 3.0.3 to 3.0.4 (UniversalMediaServer#4674)
  Bump the typescript-eslint group in /react-client with 2 updates (UniversalMediaServer#4676)
  Bump react-router-dom from 6.23.0 to 6.23.1 in /react-client (UniversalMediaServer#4679)
  Bump @playwright/test from 1.43.1 to 1.44.0 in /react-client (UniversalMediaServer#4678)
  main fix UniversalMediaServer#4653 (UniversalMediaServer#4666)
  fix crowdin name (UniversalMediaServer#4670)
  fix web player
  ...

# Conflicts:
#	src/main/java/net/pms/network/mediaserver/javahttpserver/MediaServerHandler.java
@ik666 ik666 changed the base branch from v14.1 to main May 27, 2024 06:41
sf666 added 2 commits May 27, 2024 09:39
* main_UMS:
  v14.1 (UniversalMediaServer#4649)
  main fix NullPointerException on RendererFrame.buildEditBar (UniversalMediaServer#4701)

# Conflicts:
#	pom.xml
#	src/main/java/net/pms/network/mediaserver/javahttpserver/MediaServerHandler.java
@ik666 ik666 removed the conflicting label May 27, 2024
@SubJunk
Copy link
Member

SubJunk commented May 27, 2024

Whoops I didn't test it, sorry for forgetting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants