-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle playlist of internet radio stations #4572
Open
ik666
wants to merge
919
commits into
UniversalMediaServer:main
Choose a base branch
from
ik666:bugfix/m3u_uri_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,942
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # react-client/package.json # react-client/yarn.lock
* Bump MediaInfo to 24.01 * Bump MediaInfo to 24.01.1
add Java gui option
# Conflicts: # react-client/package.json # react-client/yarn.lock
add advice how to register a TMDB API key.
# Conflicts: # react-client/package.json # react-client/yarn.lock # src/main/external-resources/documentation/index.html
# Conflicts: # pom.xml
# Conflicts: # react-client/package.json # react-client/yarn.lock
Bugfix of playback issues of composer / conductor
…sts_lc_name Do not lowercase playlist name for display.
# Conflicts: # src/main/java/net/pms/store/MediaStore.java
V14.1 merge main
…ist_title show Playlists title without extension
# Conflicts: # CHANGELOG.md
V14.1 - merge main
# Conflicts: # CHANGELOG.md
Merge ums/main into v14.1
Fixed NullPointerException on RendererFrame.buildEditBar
V14.1- Added Specials folder for TV Series
V14.1 fix navbar
@dependabot recreate |
* v14.1: (98 commits) fix navbar Added Specials folder for TV Series Fixed NullPointerException on RendererFrame.buildEditBar partial fix for UniversalMediaServer#4691 lint Serie -> Series Post-release 14.0.1 Merge ums/main into v14.1 Updated changelog check for range dc:title correction for playlists : suppress extension fix 4682 (UniversalMediaServer#4684) Bump video.js from 8.10.0 to 8.12.0 in /react-client (UniversalMediaServer#4677) Bump com.sun.xml.messaging.saaj:saaj-impl from 3.0.3 to 3.0.4 (UniversalMediaServer#4674) Bump the typescript-eslint group in /react-client with 2 updates (UniversalMediaServer#4676) Bump react-router-dom from 6.23.0 to 6.23.1 in /react-client (UniversalMediaServer#4679) Bump @playwright/test from 1.43.1 to 1.44.0 in /react-client (UniversalMediaServer#4678) main fix UniversalMediaServer#4653 (UniversalMediaServer#4666) fix crowdin name (UniversalMediaServer#4670) fix web player ... # Conflicts: # src/main/java/net/pms/network/mediaserver/javahttpserver/MediaServerHandler.java
* main_UMS: v14.1 (UniversalMediaServer#4649) main fix NullPointerException on RendererFrame.buildEditBar (UniversalMediaServer#4701) # Conflicts: # pom.xml # src/main/java/net/pms/network/mediaserver/javahttpserver/MediaServerHandler.java
Whoops I didn't test it, sorry for forgetting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added playlist support for handling internet radio stations. No transcoding yet (probably not neccesary for the usual codecs).
Feature can be tested with:
my_internet_radio_station.m3u file consists of radio stations like
VLC media player -> Universal Plug 'n Play -> UMS -> my_internet_radio_station.m3u -> radio
Netty 3 MediaServer implementation seems to have an issue serving large chunked streams and becomes more and more unresponsive over some time (a few seconds !).
JDK MediaServer implementation is much more responsive and stable over time.
server_engine
config entry should therefore be something like 1.Todo :
[x] cache radio station metadata in a table
[-] currently for for a radio station 2 resources are created, one is VLC Web Audio (probably the renderer) and one is "no transcoding". Maybe this is only cosmetic and can stay this way.
[x] read metadata from radio browser API if possible
[-] adding support for hardware audio player (not in scope any more)