Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpeg transcoder streams softsubs in MP4 #4571

Closed
wants to merge 20 commits into from
Closed

Conversation

SubJunk
Copy link
Member

@SubJunk SubJunk commented Apr 9, 2024

This means we don't have to hardcode the subtitles which saves a lot of initial processing by FFmpeg

Also muxes Dolby Vision without tsMuxeR

SubJunk and others added 4 commits April 9, 2024 20:42
…oding to MP4

This means we don't have to hardcode the subtitles which saves a lot of time
@SubJunk SubJunk requested a review from a team April 10, 2024 01:11
valib and others added 4 commits April 10, 2024 18:06
- Preserve HDR and Dolby Vision metadata
- Stop deferring to MEncoder if the subtitles can be softcoded in FFmpeg
- Mux Dolby Vision without tsMuxeR
@SubJunk SubJunk changed the title Allow FFmpeg to add attach internal SRT subtitles as TX3G when transcoding to MP4 FFmpeg transcoder streams softsubs in MP4 Apr 12, 2024
@SubJunk SubJunk removed the request for review from a team April 15, 2024 08:44
@SubJunk
Copy link
Member Author

SubJunk commented Apr 15, 2024

This is working for me on my TV. I need to do some more manual testing to make sure the subtitles are synchronized properly with the video and audio

SubJunk added a commit that referenced this pull request May 20, 2024
@SubJunk SubJunk closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants